Add more methods to Pwm<T> #140
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usbalbin
commented
Apr 19, 2023
src/timer/pwm.rs
Outdated
| self.tim.arr.write(|w| w.$arr().bits(period as u16)); | ||
| $( | ||
| self.tim.arr.modify(|_, w| w.$arr_h().bits((arr >> 16) as u16)); | ||
| self.tim.arr.modify(|_, w| w.$arr_h().bits((period >> 16) as u16)); |
There was a problem hiding this comment.
pwm! {
TIM1: (tim1, arr),
TIM3: (tim3, arr_l, arr_h), // should this really have a `arr_h`?
TIM14: (tim14, arr),
TIM16: (tim16, arr),
TIM17: (tim17, arr),
}I must say that I am a bit confused about the 16/32bit for TIM3. From what I understand from the reference manual for g0x0 TIM3 is just 16-bit. reference manual for g0x1 says pretty much the same thing except it adds a TIM2 which is 32-bit.
Looking at the pac, TIM3 does have an arr_h(inherited from tim2?), same thing when looking in the reference manual...
Also is it really safe to write to arr in two steps without the pwm signal going crazy in between the stores?
There was a problem hiding this comment.
Please correct me if I am wrong but from what I can gather, TIM3 is 16bits but does share the same memory config structure as TIM2(which is 32bit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :)
I have a use case where I need to update the frequency of several pwm outputs very often, therefore I need access to directly setting the period and/or prescaler registers. This PR does that plus some extra methods like start/pause, and access to setting the prescaler.